• Thorry84@feddit.nl
    54·
    10 months ago

    I’ve seen a changelog that said “Introduced some bugs, so we can fix them later”.

    It was a joke, but true nonetheless.

  • VBB@lemmy.world
    52·
    10 months ago

    Good opportunity to say how annoying are update notes like “We are continuing to improve our application. We fixed a couple more issues to make it more stable”. Corporate style, uselessness and the fact that this update can contain some stupid redesign is disgusting.

    • popcar2@programming.devEnglish
      7·
      10 months ago

      I’ve reached a point where I avoid these types of updates. An update post like that either means nothing important changed or they’re up to something.

      A while ago I saw that style of patch notes, updated an app, and suddenly I can’t use it anymore because it got limited to a maximum of 2 devices. Another time I updated an app putting a harmless “we improved the user experience” message, they put dark mode behind a paywall. This isn’t counting the number of times an app got redesigned to make the user experience worse for no reason. Maybe they wanted to justify hiring 5 UI/UX interns in that quarter or something.

      The patch notes look harmless, but my god, they are usually up to something.

      • MajorHavoc@programming.dev
        2·
        10 months ago

        Yeah. I do the same. That “we are making improvements” text is corporate for “we don’t have anything remotely close to change management or quality assurance”.

    • clearleaf@lemmy.world
      1·
      10 months ago

      I’m done with programs that need meaningless updates like this every day. All my patience for that was used up with flash and java.

  • Ashy@lemmy.wtf
    45·
    10 months ago

    Yep, we also got one of these:

    and pretty sure the “y” was typo.

    • MajorHavoc@programming.dev
      6·
      10 months ago

      I like to go for dark jam poetry, in those commits.

      ‘why is anything? can it be? desolation - oh wait, that variable is mistyped!’

  • kaotic@lemmy.world
    301·
    10 months ago

    Every one is using AI to make funny pictures. This is what they should be using it for. Look at my diff, generate a commit message.

  • jjjalljs@ttrpg.network
    25·
    10 months ago

    My commits when merged into main generally read like

    [Ticket-123] Summary of what was done. Eg: Return user foo property in bar endpoint

    • update bar view to return new foo key
    • update foobrinator to determine foo property
    • update tests

    It takes an extra minute or two but it’s more informative for the team / future me.

    • onlinepersona@programming.devEnglish
      52·
      10 months ago

      Mine look similar except the body is mostly “the X was doing Y, but it should’ve been doing Z” or “the docs say bla, $link”. I try to separate the individual “update A to do B” in separate commits, but sometimes it just isn’t possible.

      CC BY-NC-SA 4.0

      • jjjalljs@ttrpg.network
        3·
        10 months ago

        We squash everything (and rebase rather than merge) so I don’t worry much about the individual commits. I like that main is pretty concise and doesn’t have a ton of work-in-progess stuff in the log.

        • onlinepersona@programming.devEnglish
          62·
          10 months ago

          We are mortal enemies you and I 😄 I’d much rather have a descriptive commit history than huge commits which make git blame meaningless. Function over beauty for me.

          CC BY-NC-SA 4.0

          • jjjalljs@ttrpg.network
            3·
            10 months ago

            A nemesis! I’m pretty lucky I guess that no one at my workplace has strong git opinions that differ

            Do you have multiple people’s commits being squashed together? Or how is blame being made useless for you? I’m at a rather small company where generally it’s just one person working on a thing at a time. The blame will point to their squashed commit that, if they wrote a good message like the top of this thread, will give you a lot of context.

            • onlinepersona@programming.devEnglish
              72·
              10 months ago

              Imagine finding a bug in angularjs, doing a git blame and finding this commit

              feat(module): new module loader

              211 changed files with 1,051 additions and 1,242 deletions.

              AngularJS isn’t even the worst offender. I’ve seen backports of multiple fixes getting squashed into one commit for “a clean history” with all the useful commit messages ending up in one commit.

              Many user stories I’ve seen implemented in a sprint take multiple days to write. Sometimes they have 5+ commits with a multitude of files changed and (if done right) each commit has an explanation why something was done or at least what was done. Having a granular view of changes also allows finding related changes quickly with less code to read.
              If someone changes the implementation of a function call in one commit and it introduces a bug, it’s nice to have only that change instead of the entire class with it and changes in other files too. Additional changes mean now you have to read through more code to be sure that the function implementation change was not done due to a modification of the class or whatever else was changed which might be the actual source of the problem.

              IMO squashing commits has its uses. It’s a tool in a toolbox, but it’s not the only tool.

              CC BY-NC-SA 4.0

              • jjjalljs@ttrpg.network
                2·
                10 months ago

                That angular commit message is a crime.

                My squashed commit messages typically enumerate everything I changed and why.

                IMO squashing commits has its uses. It’s a tool in a toolbox, but it’s not the only tool.

                I think we agree on this.

                One case that has come up for me several times: working on a feature, committing as I go. And then I realize some of what I did won’t work or isn’t what product actually wants. Leaving those commits in the history that show the function doing the wrong thing would be misleading. Especially if that was never actually in production or left my local machine.

                I guess I have an unspoken belief that every commit on main should work, but you could achieve that with tags instead.

                I was recently spelunking to try to find why something in old code was the way it was. I found the commit where they changed the line, but it was orphaned from the larger context. The message didn’t say more than like “change field from footype to bartype”, but not why. So I had to try to piece together what other changes were part of this change. If it had been a single commit that showed them like adding the new field, new model, and whatnot, it would have been clearer to me that those things all go together.

  • catlover@sh.itjust.works
    23·
    10 months ago

    git commit -m ‘initial commit’

    git commit --amend

    git commit --amend

    git commit --amend

    git commit --amend

    …

    git commit --amend

  • katy ✨@lemmy.blahaj.zone
    22·
    10 months ago

    kinda like on google play how it says “what’s new: no information from the developer” or “what’s new: we regularly update our app to fix bugs, improve performance and add new features”.